-
-
Notifications
You must be signed in to change notification settings - Fork 51
Add --load-package to lintr #615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --load-package to lintr #615
Conversation
873df8c to
a741783
Compare
|
Hi @agvandervelde , do I understand correctly that you list all your package's dependencies in |
|
Yes, I list the dependencies in |
|
For styler? I don’t get it. How would the styler hook need additional dependencies? You mean roxygen? This needs to load the package as per the docs. |
Apologies, yes, roxygen. |
a741783 to
3a67ec8
Compare
|
Hi @agvandervelde, sorry this took a while... I pushed some (mildly related) doc changes to this branch too and I think this should be mergeable soon. Thanks for your work. |
|
Thank you! |
…elated to what we were testing there
- Arguments is a header and each argument doc is a bullet - All arguments are listed in the same code block (generally)
for more information, see https://pre-commit.ci
e46b850 to
8202fd0
Compare
|
Rebased this PR onto current main. |
for more information, see https://pre-commit.ci
|
Sorry did not get to merge this yet. Hope everything passes now. |
|
@agvandervelde thanks again. If you don’t want to wait till the next tag bump, you can also |
Hi @lorenzwalthert, I need to load packages prior to running
lintrin CI/CD, so I can account for "spurious" global variables (e.g., when usingbox,dplyr, etc.) usingutils::globalVariables()(see r-lib/lintr#352 (comment)). I'm currently running off of the branch on my fork but I think it'd be useful to incorporate this in your upstream. Issue #440 suggests there's a broader need for this.